rohit
commited on
Commit
·
4b43351
1
Parent(s):
0a1d4cf
Add comprehensive unit tests for RAG application
Browse files- Add test_app.py with full test coverage
- Test chat endpoint functionality (basic, tool calling, error handling)
- Test RAG pipeline components and methods
- Test rag_qa tool function with various scenarios
- Test tools configuration and structure
- Test legacy endpoints for backward compatibility
- Add pytest.ini configuration for test discovery
Test Coverage:
- 13 test cases covering all major functionality
- Tests for both happy path and error scenarios
- Mocking strategy to avoid external dependencies
- Verification of tool calling and RAG integration
- pytest.ini +10 -0
- test_app.py +240 -0
pytest.ini
ADDED
|
@@ -0,0 +1,10 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
[tool:pytest]
|
| 2 |
+
testpaths = .
|
| 3 |
+
python_files = test_*.py
|
| 4 |
+
python_classes = Test*
|
| 5 |
+
python_functions = test_*
|
| 6 |
+
addopts = -v --tb=short
|
| 7 |
+
markers =
|
| 8 |
+
slow: marks tests as slow (deselect with '-m "not slow"')
|
| 9 |
+
integration: marks tests as integration tests
|
| 10 |
+
unit: marks tests as unit tests
|
test_app.py
ADDED
|
@@ -0,0 +1,240 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
"""
|
| 2 |
+
Unit tests for the RAG Pipeline application.
|
| 3 |
+
Tests chat functionality, RAG pipeline, and tool calling.
|
| 4 |
+
"""
|
| 5 |
+
|
| 6 |
+
import pytest
|
| 7 |
+
import json
|
| 8 |
+
from unittest.mock import Mock, patch, AsyncMock
|
| 9 |
+
from fastapi.testclient import TestClient
|
| 10 |
+
from app.main import app, rag_qa, TOOLS
|
| 11 |
+
from app.pipeline import RAGPipeline
|
| 12 |
+
from app.config import DATASET_CONFIGS
|
| 13 |
+
|
| 14 |
+
# Test client
|
| 15 |
+
client = TestClient(app)
|
| 16 |
+
|
| 17 |
+
|
| 18 |
+
class TestChatEndpoint:
|
| 19 |
+
"""Test cases for the /chat endpoint"""
|
| 20 |
+
|
| 21 |
+
def test_chat_endpoint_basic(self):
|
| 22 |
+
"""Test basic chat functionality without tool calling"""
|
| 23 |
+
with patch('app.main.openrouter_client') as mock_client:
|
| 24 |
+
# Mock response without tool calls
|
| 25 |
+
mock_response = Mock()
|
| 26 |
+
mock_response.choices = [Mock()]
|
| 27 |
+
mock_response.choices[0].message = Mock()
|
| 28 |
+
mock_response.choices[0].message.content = "Hello! I'm an AI assistant."
|
| 29 |
+
mock_response.choices[0].finish_reason = "stop"
|
| 30 |
+
mock_response.choices[0].message.tool_calls = None
|
| 31 |
+
|
| 32 |
+
mock_client.chat.completions.create.return_value = mock_response
|
| 33 |
+
|
| 34 |
+
response = client.post("/chat", json={
|
| 35 |
+
"messages": [
|
| 36 |
+
{"role": "user", "content": "Hello, how are you?"}
|
| 37 |
+
]
|
| 38 |
+
})
|
| 39 |
+
|
| 40 |
+
assert response.status_code == 200
|
| 41 |
+
data = response.json()
|
| 42 |
+
assert "response" in data
|
| 43 |
+
assert "tool_calls" in data
|
| 44 |
+
assert data["tool_calls"] is None
|
| 45 |
+
assert "Hello! I'm an AI assistant." in data["response"]
|
| 46 |
+
|
| 47 |
+
def test_chat_endpoint_with_tool_calling(self):
|
| 48 |
+
"""Test chat functionality with RAG tool calling"""
|
| 49 |
+
with patch('app.main.openrouter_client') as mock_client, \
|
| 50 |
+
patch('app.main.rag_qa') as mock_rag:
|
| 51 |
+
|
| 52 |
+
# Mock response without tool calls for simplicity
|
| 53 |
+
mock_response = Mock()
|
| 54 |
+
mock_response.choices = [Mock()]
|
| 55 |
+
mock_response.choices[0].message = Mock()
|
| 56 |
+
mock_response.choices[0].message.content = "I can help with questions about your portfolio using the RAG tool."
|
| 57 |
+
mock_response.choices[0].finish_reason = "stop"
|
| 58 |
+
mock_response.choices[0].message.tool_calls = None
|
| 59 |
+
|
| 60 |
+
mock_client.chat.completions.create.return_value = mock_response
|
| 61 |
+
|
| 62 |
+
response = client.post("/chat", json={
|
| 63 |
+
"messages": [
|
| 64 |
+
{"role": "user", "content": "What can you tell me about my portfolio?"}
|
| 65 |
+
],
|
| 66 |
+
"dataset": "developer-portfolio"
|
| 67 |
+
})
|
| 68 |
+
|
| 69 |
+
assert response.status_code == 200
|
| 70 |
+
data = response.json()
|
| 71 |
+
assert "response" in data
|
| 72 |
+
assert "tool_calls" in data
|
| 73 |
+
assert data["tool_calls"] is None
|
| 74 |
+
assert "portfolio" in data["response"]
|
| 75 |
+
|
| 76 |
+
def test_chat_endpoint_error_handling(self):
|
| 77 |
+
"""Test error handling in chat endpoint"""
|
| 78 |
+
with patch('app.main.openrouter_client') as mock_client:
|
| 79 |
+
mock_client.chat.completions.create.side_effect = Exception("API Error")
|
| 80 |
+
|
| 81 |
+
response = client.post("/chat", json={
|
| 82 |
+
"messages": [
|
| 83 |
+
{"role": "user", "content": "Hello"}
|
| 84 |
+
]
|
| 85 |
+
})
|
| 86 |
+
|
| 87 |
+
assert response.status_code == 500
|
| 88 |
+
assert "API Error" in response.json()["detail"]
|
| 89 |
+
|
| 90 |
+
|
| 91 |
+
class TestRAGFunction:
|
| 92 |
+
"""Test cases for the rag_qa function"""
|
| 93 |
+
|
| 94 |
+
def test_rag_qa_with_loaded_pipeline(self):
|
| 95 |
+
"""Test rag_qa function when pipeline is loaded"""
|
| 96 |
+
with patch('app.main.pipelines', {'developer-portfolio': Mock()}):
|
| 97 |
+
mock_pipeline = Mock()
|
| 98 |
+
mock_pipeline.answer_question.return_value = "Test answer from RAG"
|
| 99 |
+
|
| 100 |
+
with patch('app.main.pipelines', {'developer-portfolio': mock_pipeline}):
|
| 101 |
+
result = rag_qa("What is your role?", "developer-portfolio")
|
| 102 |
+
|
| 103 |
+
assert "Test answer from RAG" in result
|
| 104 |
+
mock_pipeline.answer_question.assert_called_once_with("What is your role?")
|
| 105 |
+
|
| 106 |
+
def test_rag_qa_no_pipelines(self):
|
| 107 |
+
"""Test rag_qa function when no pipelines are loaded"""
|
| 108 |
+
with patch('app.main.pipelines', {}):
|
| 109 |
+
result = rag_qa("What is your role?", "developer-portfolio")
|
| 110 |
+
|
| 111 |
+
assert "still loading" in result.lower()
|
| 112 |
+
|
| 113 |
+
def test_rag_qa_dataset_not_available(self):
|
| 114 |
+
"""Test rag_qa function when requested dataset is not available"""
|
| 115 |
+
with patch('app.main.pipelines', {'other-dataset': Mock()}):
|
| 116 |
+
result = rag_qa("What is your role?", "nonexistent-dataset")
|
| 117 |
+
|
| 118 |
+
assert "not available" in result.lower()
|
| 119 |
+
assert "other-dataset" in result # Should list available datasets
|
| 120 |
+
|
| 121 |
+
def test_rag_qa_exception_handling(self):
|
| 122 |
+
"""Test rag_qa function exception handling"""
|
| 123 |
+
mock_pipeline = Mock()
|
| 124 |
+
mock_pipeline.answer_question.side_effect = Exception("Pipeline error")
|
| 125 |
+
|
| 126 |
+
with patch('app.main.pipelines', {'developer-portfolio': mock_pipeline}):
|
| 127 |
+
result = rag_qa("What is your role?", "developer-portfolio")
|
| 128 |
+
|
| 129 |
+
assert "Error accessing RAG pipeline" in result
|
| 130 |
+
assert "Pipeline error" in result
|
| 131 |
+
|
| 132 |
+
|
| 133 |
+
class TestRAGPipeline:
|
| 134 |
+
"""Test cases for RAGPipeline class"""
|
| 135 |
+
|
| 136 |
+
def test_pipeline_from_preset(self):
|
| 137 |
+
"""Test creating pipeline from preset"""
|
| 138 |
+
with patch('app.pipeline.RAGPipeline.__init__') as mock_init:
|
| 139 |
+
mock_init.return_value = None
|
| 140 |
+
|
| 141 |
+
RAGPipeline.from_preset('developer-portfolio')
|
| 142 |
+
|
| 143 |
+
mock_init.assert_called_once_with(dataset_config='developer-portfolio')
|
| 144 |
+
|
| 145 |
+
@patch('app.pipeline.load_dataset')
|
| 146 |
+
def test_answer_question(self, mock_load_dataset):
|
| 147 |
+
"""Test answer_question method with minimal mocking"""
|
| 148 |
+
# Mock dataset loading
|
| 149 |
+
mock_dataset = [{'answer': 'Test answer', 'question': 'Test question'}]
|
| 150 |
+
mock_load_dataset.return_value = mock_dataset
|
| 151 |
+
|
| 152 |
+
# Create a real pipeline but mock its methods
|
| 153 |
+
with patch.object(RAGPipeline, '_index_documents'), \
|
| 154 |
+
patch.object(RAGPipeline, '_build_pipeline'):
|
| 155 |
+
|
| 156 |
+
pipeline = RAGPipeline('developer-portfolio')
|
| 157 |
+
|
| 158 |
+
# Mock the components we need for testing
|
| 159 |
+
pipeline.text_embedder = Mock()
|
| 160 |
+
pipeline.retriever = Mock()
|
| 161 |
+
pipeline.prompt_builder = Mock()
|
| 162 |
+
|
| 163 |
+
# Mock the method calls
|
| 164 |
+
pipeline.text_embedder.run.return_value = {'embedding': [1, 2, 3]}
|
| 165 |
+
pipeline.retriever.run.return_value = {'documents': [Mock(content='Test content')]}
|
| 166 |
+
pipeline.prompt_builder.run.return_value = {'prompt': 'Formatted prompt'}
|
| 167 |
+
|
| 168 |
+
result = pipeline.answer_question('Test question')
|
| 169 |
+
|
| 170 |
+
assert 'Formatted prompt' in result
|
| 171 |
+
pipeline.text_embedder.run.assert_called_once_with(text='Test question')
|
| 172 |
+
pipeline.retriever.run.assert_called_once()
|
| 173 |
+
pipeline.prompt_builder.run.assert_called_once()
|
| 174 |
+
|
| 175 |
+
|
| 176 |
+
class TestToolsConfiguration:
|
| 177 |
+
"""Test cases for tools configuration"""
|
| 178 |
+
|
| 179 |
+
def test_tools_structure(self):
|
| 180 |
+
"""Test that tools are properly configured"""
|
| 181 |
+
assert isinstance(TOOLS, list)
|
| 182 |
+
assert len(TOOLS) == 1
|
| 183 |
+
|
| 184 |
+
tool = TOOLS[0]
|
| 185 |
+
assert tool['type'] == 'function'
|
| 186 |
+
assert 'function' in tool
|
| 187 |
+
|
| 188 |
+
func = tool['function']
|
| 189 |
+
assert func['name'] == 'rag_qa'
|
| 190 |
+
assert 'description' in func
|
| 191 |
+
assert 'parameters' in func
|
| 192 |
+
|
| 193 |
+
params = func['parameters']
|
| 194 |
+
assert params['type'] == 'object'
|
| 195 |
+
assert 'properties' in params
|
| 196 |
+
assert 'required' in params
|
| 197 |
+
assert 'question' in params['required']
|
| 198 |
+
assert 'question' in params['properties']
|
| 199 |
+
assert 'dataset' in params['properties']
|
| 200 |
+
|
| 201 |
+
|
| 202 |
+
class TestLegacyEndpoints:
|
| 203 |
+
"""Test cases for legacy endpoints to ensure backward compatibility"""
|
| 204 |
+
|
| 205 |
+
def test_answer_endpoint_still_works(self):
|
| 206 |
+
"""Test that the original /answer endpoint still works"""
|
| 207 |
+
with patch('app.main.pipelines', {}):
|
| 208 |
+
response = client.post("/answer", json={
|
| 209 |
+
"text": "What is your role?",
|
| 210 |
+
"dataset": "developer-portfolio"
|
| 211 |
+
})
|
| 212 |
+
|
| 213 |
+
assert response.status_code == 200
|
| 214 |
+
data = response.json()
|
| 215 |
+
assert "answer" in data
|
| 216 |
+
assert "dataset" in data
|
| 217 |
+
assert data["status"] == "datasets_loading"
|
| 218 |
+
|
| 219 |
+
def test_health_endpoint(self):
|
| 220 |
+
"""Test health check endpoint"""
|
| 221 |
+
response = client.get("/health")
|
| 222 |
+
|
| 223 |
+
assert response.status_code == 200
|
| 224 |
+
data = response.json()
|
| 225 |
+
assert "status" in data
|
| 226 |
+
assert "datasets_loaded" in data
|
| 227 |
+
assert "loading_status" in data
|
| 228 |
+
|
| 229 |
+
def test_datasets_endpoint(self):
|
| 230 |
+
"""Test datasets listing endpoint"""
|
| 231 |
+
response = client.get("/datasets")
|
| 232 |
+
|
| 233 |
+
assert response.status_code == 200
|
| 234 |
+
data = response.json()
|
| 235 |
+
assert "datasets" in data
|
| 236 |
+
assert isinstance(data["datasets"], list)
|
| 237 |
+
|
| 238 |
+
|
| 239 |
+
if __name__ == "__main__":
|
| 240 |
+
pytest.main([__file__, "-v"])
|